Updating to most recent version of libnfs - #18
Open
tryggvil wants to merge 5 commits into
Open
Conversation
tryggvil
commented
Nov 1, 2024
tryggvil
commented
- Updating to most recent version of libnfs master
- Updating nix crate
- Changing Rc to Arc
- Removing problematic redeclaration of nfs_url struct
cholcombe973
reviewed
Nov 3, 2024
| libc = "~0.2" | ||
| libnfs-sys = "~0.2" | ||
| nix = "~0.25" | ||
| #libnfs-sys = "~0.2" |
Owner
There was a problem hiding this comment.
We'll need to change this to the published version again. I'll push that change to crates.io shortly
| #[derive(Clone)] | ||
| struct NfsPtr(*mut nfs_context); | ||
|
|
||
| unsafe impl Send for NfsPtr{} |
Owner
There was a problem hiding this comment.
I think back when I first wrote this I tried to figure out if the nfs pointer is thread safe. Could you point me towards some code or docs?
Author
There was a problem hiding this comment.
I updated the implementation to enclose nfs_context within a Mutex to implement safe Send
Owner
|
I found my old issue I opened with LibNFS: sahlberg/libnfs#266. It's not thread safe so we shouldn't impl Send/Sync |
... so that reads/writes happen in chunks where maximum chunk size comes from max read/write size obtained via libnfs functions nfs_get_readmax/nfs_get_writemax, respectively.
Now references our forked repo and its version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.