Skip to content

Fix mysql reconnection test: proxy must close both sides on planned disconnect #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix mysql reconnection test: proxy must close both sides on planned disconnect #49

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4357b07
Initial plan
Copilot Mar 2, 2026
8589e08
Fix MySQL binlog_proxy.py to properly disconnect both sides for recon…
Copilot Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions docker/mysql_tests/scripts/utils/binlog_proxy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ def handle_client_connection(self, client_socket):

if not self.connect_to_server():
print("[Proxy] Initial connection to server failed")
client_socket.close()
return

self.connection_start_time = time.time()
Expand All @@ -62,21 +63,18 @@ def handle_client_connection(self, client_socket):
print(f"[Proxy] Planned disconnect #{self.disconnect_count + 1}/{self.planned_disconnects} after {self.bytes_transferred} bytes")
print(f"[Proxy] Total bytes transferred so far: {self.total_bytes_transferred}")

self.server_socket.close()
time.sleep(2)

self.disconnect_count += 1

if self.disconnect_count >= self.planned_disconnects:
self.disconnects_completed = True
print(f"[Proxy] Completed all {self.planned_disconnects} planned disconnects. Now working in stable mode.")

if not self.connect_to_server():
print("[Proxy] Reconnection failed, closing client connection")
break

self.connection_start_time = time.time()
self.bytes_transferred = 0
print(f"[Proxy] Completed all {self.planned_disconnects} planned disconnects. Next connection will be stable.")

# Close both connections to force MySQL to reconnect with its current
# GTID set. Reconnecting only the server side would corrupt the
# replication protocol by sending a new MySQL handshake to MySQL
# while it expects binlog events.
print(f"[Proxy] Closing both connections to force client reconnect")
return

try:
ready_sockets, _, error_sockets = select.select(
Expand Down