fix(analysers): Don't raise an exception on absent data.#210
Merged
Conversation
ljgray
previously approved these changes
Jul 8, 2025
A lack of data isn't an error (at least not an error for dias: if it's not there, someone else needs to worry about it).
ketiltrout
force-pushed
the
remove_out_of_data_error
branch
from
July 8, 2025 16:22
3c76260 to
f28b716
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lack of data isn't an error (at least not an error for dias: if it's not there, someone else needs to worry about it).
(Part of an attempt to make the "Dias Task Failed" alert actually useful.)