feat(core): Add a non-endpoint /qlen route#297
Open
ketiltrout wants to merge 1 commit into
Open
Conversation
ketiltrout
marked this pull request as draft
July 15, 2026 20:00
ketiltrout
changed the title
ketiltrout
changed the title
ketiltrout
marked this pull request as ready for review
July 16, 2026 01:08
This is the first part of the promethues metrics client fix. The goal here is to remove the need for prometheus in the client. The client used to fetch the `/metrics` from the metrics server and then extract the queue length from that to report to the user the queue length. But Sanic can just as easily fetch the queue length from redis as the metric server (which runs in qworker proces) can. So, I've implemented a non-endpoint route `/qlen` which simply returns the queue length (as plain text) when hit. This removes the `prometheus_client` from the client.
ljgray
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first part of the promethues metrics client fix. The goal here is to remove the need for prometheus in the client.
The client used to fetch the
/metricsfrom the metrics server and then extract the queue length from that to report to the user the queue length.But Sanic can just as easily fetch the queue length from redis as the metric server (which runs in qworker proces) can. So, I've implemented a non-endpoint route
/qlenwhich simply returns the queue length (as plain text) when hit.For ease of testing only, this requires #296.