fix(core): Let sanic manage the qworker process#295
Merged
Conversation
This seems like the only robust way to have additional processes running in Sanic. I haven't found a good way to write a unit test to check the workings here because of the way subprocess creation is working, but manually testing (by inserting a crash directly into the qworker) seems to indicate that a crashing qworker will now crash all of cocod, which will at least save us from the half-dead cocod situation (e.g. #249). Closes #290
ketiltrout
force-pushed
the
sanic_manages_qworker
branch
from
57c1650 to
3a30a04
Compare
Closed
ljgray
reviewed
Jul 14, 2026
ljgray
approved these changes
Jul 14, 2026
This was referenced Jul 15, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems like the only robust way to have additional processes running in Sanic.
I haven't found a good way to write a unit test to check the workings here because of the way subprocess creation is working, but manually testing (by inserting a crash directly into the qworker) seems to indicate that a crashing qworker will now crash all of cocod, which will at least save us from the half-dead cocod situation (e.g. #249).
Closes #89
Closes #290