Pre-client-rewrite minor fixes#289
Merged
Merged
Conversation
Two things: * restore the `Endpoint.timestamp_path` assignment inadvertently deleted * Validate keys in the endpoing "call" dictionary.
It was getting doubly JSON encoded.
ketiltrout
force-pushed
the
pre-client_minor_fixes
branch
from
June 25, 2026 21:23
38f9a84 to
be731cd
Compare
tristpinsm
reviewed
Jun 25, 2026
tristpinsm
reviewed
Jun 25, 2026
ketiltrout
force-pushed
the
pre-client_minor_fixes
branch
from
June 25, 2026 23:34
be731cd to
8579c51
Compare
Member
Author
|
I've added another commit which changes the |
Also some doc updates.
ketiltrout
force-pushed
the
pre-client_minor_fixes
branch
from
June 26, 2026 00:11
53eb580 to
f737322
Compare
Instead of returning a function to instantiate the runner, now `coco_runner` just does it directly. If you need to set daemon command-line arguments, use `start_daemon`. If you want to avoid starting the daemon when running the client, use the `no_daemon` keyword argument with the (still unimplemented) `client` method.
ketiltrout
force-pushed
the
pre-client_minor_fixes
branch
from
June 26, 2026 00:19
f737322 to
7c6f6a1
Compare
ljgray
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One (hopefully) last PR with some minor fixes before the re-written client is done.
There are four to six things here, depending on how you count:
Endpoint.timestamp_pathassignment I accidentally deleted in fix(endpoint): Validate endpoint config earlier #287rest_servertest fixture so it doesn't double-encode the request body.portandtargetproperties to thecoco_runnerso tests can access them. Also some doc updates there.coco_runnerfixture now just instantiates theCocoRunnerimmediately, instead of requiring the test to do that.