refactor(finder): Search active archive nodes by default#107
Merged
Conversation
This changes what the `Finder` does when _not_ given a `node_spoof`. In the past, in this case, `Finder` would look at the local hostname and try to match that against host values in the database. This was never a good default and almost always _not_ what a user would want, since it would only be useful if running `Finder` on a machine which also happened to be running the alpenhorn daemon. As a result, we almost always use `node_spoof` when running `Finder`. This changes the default node list to not consider the local hostname, and instead just look at _all_ the currently active archive nodes. This ensures users will find anything that matches their query, even though they may not know where the file is. Alpenhorn per se has slowly migrated the meaning of the "host" field. Now alpenhorn's "host" field is typically a logical value (like "scinet" or "fir"), which doesn't correspond to any local hostname and the value used is set in the daemon's config file.
ketiltrout
force-pushed
the
node_spoof_default
branch
from
cb10f4b to
5c812bd
Compare
ljgray
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes what the
Finderdoes when not given anode_spoof.In the past, in this case,
Finderwould look at the local hostname and try to match that against host values in the database. This was never a good default and almost always not what a user would want, since it would only be useful if runningFinderon a machine whichalso happened to be running the alpenhorn daemon. As a result, we
almost always use
node_spoofwhen runningFinder.This changes the default node list to not consider the local hostname, and instead just look at all the currently active archive nodes. This ensures users will find anything that matches their query, even though they may not know where the file is.
Alpenhorn per se has slowly migrated the meaning of the "host" field. Now alpenhorn's "host" field is typically a logical value (like "scinet" or "fir"), which doesn't correspond to any local hostname and the value used is set in the daemon's config file.
Requires chime-experiment/chimedb_di#33