Skip to content

Update imports for caput refactor#105

Merged
ljgray merged 5 commits into
masterfrom
refactor-dev
Jan 31, 2026
Merged

Update imports for caput refactor#105
ljgray merged 5 commits into
masterfrom
refactor-dev

Conversation

@ljgray

@ljgray ljgray commented Jan 7, 2026

Copy link
Copy Markdown
Contributor

@ljgray ljgray force-pushed the refactor-dev branch 2 times, most recently from cdd2fbc to 9db2658 Compare January 29, 2026 00:59

@ketiltrout ketiltrout left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed some BasicConts. Also I think it's worth taking a moment to think about _typeutils.

Comment thread ch_util/andata.py Outdated
Comment thread ch_util/andata.py Outdated
Comment thread ch_util/ni_utils.py Outdated
Comment thread ch_util/ni_utils.py Outdated
@ljgray

ljgray commented Jan 30, 2026

Copy link
Copy Markdown
Contributor Author

Also I think it's worth taking a moment to think about _typeutils.

On one hand, it somewhat suggests that we should update andata to be more consistent with memdata (We already have a CHIMETimeStream container in ch_pipeline that can load these files, but I think there's still something missing). I'm open to moving typeutils to caput.util, though, since it's pretty generic and shouldn't be a complicated change.

@ljgray ljgray force-pushed the refactor-dev branch 2 times, most recently from 9b51593 to 4f7a0ee Compare January 30, 2026 22:04
@ljgray ljgray requested a review from ketiltrout January 30, 2026 22:04
@ljgray ljgray dismissed ketiltrout’s stale review January 31, 2026 01:55

Addressed necessary changes

@ljgray ljgray merged commit 7f4541e into master Jan 31, 2026
5 checks passed
@ljgray ljgray deleted the refactor-dev branch January 31, 2026 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants