fix: check-and-restart job was silently skipping every time (implicit success())

actions/format/docs/for-caller-repos/example-caller-text-extraction.yml

@@ -41,12 +41,17 @@ jobs:
             echo "⚠️  Summary file not found"
           fi
 
-  # Auto-restart job if extraction was cancelled (timeout) or failed
+  # Auto-restart job if extraction was cancelled (timeout) or failed.
+  # The `always() &&` is load-bearing: GitHub Actions implicitly ANDs a
+  # job's if: with success() unless the condition calls a status-check
+  # function (always/success/failure/cancelled) -- without it, this job
+  # silently skips every time, since the needed job having failed makes
+  # the implicit success() false regardless of the explicit check below.
   check-and-restart:
     name: Check Status & Restart if Needed
     needs: extract-text
     runs-on: ubuntu-latest
-    if: needs.extract-text.result == 'cancelled' || needs.extract-text.result == 'failure'
+    if: always() && (needs.extract-text.result == 'cancelled' || needs.extract-text.result == 'failure')
     permissions:
       actions: write
       contents: read

actions/pipeline-manager/templates/openstates-to-ocd-files/.github/workflows/extract-text.yml

@@ -66,12 +66,20 @@ jobs:
             echo "⚠️  Summary file not found"
           fi
 
-  # Auto-restart job if extraction was cancelled (timeout) or failed
+  # Auto-restart job if extraction was cancelled (timeout) or failed.
+  #
+  # The `always() &&` is load-bearing, not decoration: GitHub Actions
+  # implicitly ANDs a job's `if:` with success() unless the condition
+  # explicitly calls a status-check function (always/success/failure/
+  # cancelled). Without it, this job silently skipped every single time --
+  # confirmed across every real failure/cancellation this repo has hit so
+  # far (it never once ran) -- because the needed job having failed made
+  # the implicit success() false regardless of the explicit check below.
   check-and-restart:
     name: Check Status & Restart if Needed
     needs: extract-text
     runs-on: ubuntu-latest
-    if: needs.extract-text.result == 'cancelled' || needs.extract-text.result == 'failure'
+    if: always() && (needs.extract-text.result == 'cancelled' || needs.extract-text.result == 'failure')
     permissions:
       actions: write
       contents: read