fix: scrape.sh incremental auto-save + chmod permission fix + branch threading#74
Open
tamara-builds wants to merge 1 commit into
Open
fix: scrape.sh incremental auto-save + chmod permission fix + branch threading#74tamara-builds wants to merge 1 commit into
tamara-builds wants to merge 1 commit into
Conversation
…reading Adds a 30-minute background auto-save loop to scrape.sh, mirroring the existing pattern in actions/extract, so a runner crash or lost connection mid-scrape (e.g. FL's 21-hour run that lost all progress) only costs the last ~30 minutes instead of the entire run. Also fixes a chmod permission bug where the tarball-packaging step operated on Docker-root-owned files instead of the already-copied runner-owned output, silently killing the script under set -e on Linux runners (surfacing as a false "Nightly fallback" job summary despite real data landing) -- and threads the branch input through to scrape.sh so the new auto-save pushes to the right branch instead of assuming main. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scrape.sh(mirroringactions/extract's existing pattern) so a runner crash or lost connection mid-scrape only costs the last ~30 minutes of progress instead of the entire run. Prompted directly by FL's 21-hour self-hosted scrape that lost all progress to "runner lost communication with the server."chmod -R 755against the Docker-root-owned source directory instead of the already-copied runner-owned output. On Linux runners this fails withOperation not permittedand (underset -e) silently kills the rest of the script — surfacing as a false "📦 Nightly fallback" job summary with all-N/A stats, even when real data landed and got committed fine. Found live on WI and SD.branchthrough as a new argument toscrape.shso the new auto-save loop pushes to the correct branch instead of assumingmain.Test plan
🤖 Generated with Claude Code