Govbot Windows - #17
Open
sartaj wants to merge 4 commits into
Open
Conversation
Replaces unconditional `std::os::unix::fs::PermissionsExt::set_mode(0o777)` calls in the robust-removal helper with a `make_writable` helper that uses the unix mode bits on Unix and `Permissions::set_readonly(false)` on Windows. Replaces the `rm -rf` shell fallback in `delete_repo` with a `shell_remove_dir` helper that dispatches to `rm -rf` on Unix and `cmd /C rmdir /S /Q` on Windows. Makes `govbot update` return a manual-install pointer on Windows rather than shelling out to `sh -c "curl ... | sh"`. Verified `cargo check` succeeds on `x86_64-unknown-linux-gnu` and `x86_64-pc-windows-gnu` with no new warnings. https://claude.ai/code/session_01BMdLaSsbHFKTwHXZwPTsrD
validate-snapshots.yml: expand govbot-snapshots job from ubuntu-only to a matrix of ubuntu-latest / macos-latest / windows-latest so that cargo test runs on all three platforms on every PR touching actions/govbot/. Also corrects the cargo target cache path (target/ -> actions/govbot/target/) so the cache key actually covers the build artefacts. release-nightly.yml: add a windows-latest build entry targeting x86_64-pc-windows-msvc. Introduces a `binary` matrix field (govbot vs govbot.exe) so the upload-artifact step resolves the correct binary name per platform. The Windows artefact is named govbot-windows-x86_64.exe and is included in nightly releases alongside the existing Linux and macOS binaries. https://claude.ai/code/session_01BMdLaSsbHFKTwHXZwPTsrD
…h fixtures actions/format/snapshots/wy/ contains OCD-style paths with literal ':' characters, which Windows/NTFS can't check out. That made actions/checkout fail outright on windows-latest runners for jobs that only need actions/govbot/, before any govbot code could run.
actions/checkout's sparse-checkout input alone doesn't avoid the colon-path failure: without a sparse index, git still builds a full index (validating every tree path, even skip-worktree ones) before applying the sparse pattern. Check out manually with `sparse-checkout --cone --sparse-index` on windows-latest so actions/format is never expanded into individual blob entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make Govbot Work On Windows