lua format#41
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 38acd852c5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| uses: JohnnyMorganz/stylua-action@v4 | ||
| with: | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
| version: latest |
There was a problem hiding this comment.
Disable the setup action's implicit StyLua run
In this workflow section, JohnnyMorganz/stylua-action@v4 is being used as an installer before the explicit make stylua-check step, but the action's documented contract makes args the command it runs and says to use args: false for install-only usage. Without that input, this step invokes stylua before line 43 rather than just adding it to PATH, so the smoke job can fail at the install step or mutate the workspace before the intended check. Add args: false here, or pass the full --check ... arguments directly to this action.
Useful? React with 👍 / 👎.
No description provided.