Skip to content

lua format#41

Open
chetmancini wants to merge 1 commit into
masterfrom
keen-cheetah-071
Open

lua format#41
chetmancini wants to merge 1 commit into
masterfrom
keen-cheetah-071

Conversation

@chetmancini

Copy link
Copy Markdown
Owner

No description provided.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 38acd852c5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +25 to +28
uses: JohnnyMorganz/stylua-action@v4
with:
token: ${{ secrets.GITHUB_TOKEN }}
version: latest

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Disable the setup action's implicit StyLua run

In this workflow section, JohnnyMorganz/stylua-action@v4 is being used as an installer before the explicit make stylua-check step, but the action's documented contract makes args the command it runs and says to use args: false for install-only usage. Without that input, this step invokes stylua before line 43 rather than just adding it to PATH, so the smoke job can fail at the install step or mutate the workspace before the intended check. Add args: false here, or pass the full --check ... arguments directly to this action.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant