fix(cmdeploy): Rewrite dovecot install logic, update#862
Draft
Conversation
Contributor
|
There was some reason why we didn't want to download and install this on every run, @link2xt do you remember? |
Contributor
Author
While I still do have a hunch I may be barking up the wrong tree here, regarding this specifically, it wouldn't, as long as the chatmail repo and the hashes/versions are not touched it won't do it. |
The old code did not install updates when the service was running; check installed version instead of systemd status. Also, rewrite install logic to extract dovecot version and hashes as module-level constants.
j4n
temporarily deployed
to
staging-ipv4.testrun.org
GitHub Actions
Inactive
j4n
temporarily deployed
to
staging2.testrun.org
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old code did not install updates when the service was running; check
installed version instead of systemd status. Also, rewrite install logic
to extract dovecot version and hashes as module-level constants.