feat(tools): add question tool with inline editor#3069
Conversation
ff98a03 to
e6a432e
Compare
e6a432e to
ce1c81d
Compare
53de1ea to
e817fb3
Compare
|
crush tends to not ask questions because of the system prompt, what do you think of adjusting it? |
|
thats not a bad idea; personally i haven't noticed a huge lack of asking questions in my testing if you are seeing it more then that might be a good idea |
|
Questions shouldn’t be asked too often, otherwise it will become annoying for the user. Right now, the frequency of questions seems fine to me |
|
in my experience it sometimes overthinks and keeps in a loop instead of asking question, sometimes I just have to stop and tell the agent to ask me questions and then it can move on. this is specially true with kimi k2.6 |
|
yeah that is a bit of a problem with kimi; it doesn't happen as much with other models in my experience. Either disabling thinking or setting reasoning level to low on kimi usually works pretty well for me |
|
Everything seems to be working well. You can clean up the extra interface (BatchService iface), but overall this shouldn’t block the merge |
e817fb3 to
41dbde7
Compare
f52b9cd to
a5a2ec8
Compare
271a734 to
d59743f
Compare
d59743f to
31b8be0
Compare
e6163e8 to
e0303ff
Compare
263bf0b to
16dc4ba
Compare
|
lgtm |
8849004 to
1157b12
Compare
93ea39e to
38a68c4
Compare
38a68c4 to
953480c
Compare

This builds on the excellent work in #2980 and #2579 to implement an ask-question tool in a few different forms:
Co-authored by: @vadiminshakov
Co-authored by: @detro