Skip to content

feat(tools): add question tool with inline editor#3069

Draft
taciturnaxolotl wants to merge 3 commits into
mainfrom
question-tool
Draft

feat(tools): add question tool with inline editor#3069
taciturnaxolotl wants to merge 3 commits into
mainfrom
question-tool

Conversation

@taciturnaxolotl
Copy link
Copy Markdown
Member

@taciturnaxolotl taciturnaxolotl commented Jun 2, 2026

This builds on the excellent work in #2980 and #2579 to implement an ask-question tool in a few different forms:

  • Binary (Yes/No)
  • Multiple options, single choice
  • Multiple choice
  • Question series

Co-authored by: @vadiminshakov
Co-authored by: @detro

@taciturnaxolotl taciturnaxolotl force-pushed the question-tool branch 2 times, most recently from ff98a03 to e6a432e Compare June 2, 2026 20:26
@meowgorithm meowgorithm changed the title feat(question): add question tool with inline editor feat(tools): add question tool with inline editor Jun 2, 2026
Comment thread internal/question/question.go
Comment thread internal/question/question.go Outdated
@taciturnaxolotl taciturnaxolotl force-pushed the question-tool branch 10 times, most recently from 53de1ea to e817fb3 Compare June 3, 2026 14:17
@dcu
Copy link
Copy Markdown

dcu commented Jun 3, 2026

crush tends to not ask questions because of the system prompt, what do you think of adjusting it?

@taciturnaxolotl
Copy link
Copy Markdown
Member Author

thats not a bad idea; personally i haven't noticed a huge lack of asking questions in my testing if you are seeing it more then that might be a good idea

@taciturnaxolotl
Copy link
Copy Markdown
Member Author

for example it just prompted me with a question while editing my jj config

image

@vadiminshakov
Copy link
Copy Markdown
Contributor

Questions shouldn’t be asked too often, otherwise it will become annoying for the user. Right now, the frequency of questions seems fine to me

@dcu
Copy link
Copy Markdown

dcu commented Jun 3, 2026

in my experience it sometimes overthinks and keeps in a loop instead of asking question, sometimes I just have to stop and tell the agent to ask me questions and then it can move on. this is specially true with kimi k2.6

@taciturnaxolotl
Copy link
Copy Markdown
Member Author

yeah that is a bit of a problem with kimi; it doesn't happen as much with other models in my experience. Either disabling thinking or setting reasoning level to low on kimi usually works pretty well for me

@vadiminshakov
Copy link
Copy Markdown
Contributor

vadiminshakov commented Jun 3, 2026

Everything seems to be working well. You can clean up the extra interface (BatchService iface), but overall this shouldn’t block the merge

Comment thread internal/pubsub/events.go Outdated
Comment thread internal/ui/model/ui.go Outdated
@taciturnaxolotl taciturnaxolotl force-pushed the question-tool branch 2 times, most recently from f52b9cd to a5a2ec8 Compare June 3, 2026 19:55
Comment thread internal/ui/dialog/question_form.go
@taciturnaxolotl taciturnaxolotl force-pushed the question-tool branch 5 times, most recently from 271a734 to d59743f Compare June 4, 2026 02:05
Comment thread internal/question/question.go Outdated
Comment thread internal/question/question.go Outdated
Comment thread internal/question/question.go Outdated
@taciturnaxolotl taciturnaxolotl force-pushed the question-tool branch 2 times, most recently from e6163e8 to e0303ff Compare June 4, 2026 15:23
Comment thread internal/question/question.go Outdated
@taciturnaxolotl taciturnaxolotl force-pushed the question-tool branch 4 times, most recently from 263bf0b to 16dc4ba Compare June 4, 2026 19:46
@vadiminshakov
Copy link
Copy Markdown
Contributor

lgtm

@taciturnaxolotl taciturnaxolotl force-pushed the question-tool branch 4 times, most recently from 8849004 to 1157b12 Compare June 5, 2026 16:10
@taciturnaxolotl taciturnaxolotl force-pushed the question-tool branch 2 times, most recently from 93ea39e to 38a68c4 Compare June 5, 2026 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants