feat(field): use aria-errormessage for error text association#3883
Open
justintoman wants to merge 1 commit into
Open
feat(field): use aria-errormessage for error text association#3883justintoman wants to merge 1 commit into
justintoman wants to merge 1 commit into
Conversation
|
@justintoman is attempting to deploy a commit to the Chakra UI Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Field.ErrorTextis currently associated with the control viaaria-describedby. I believearia-errormessageis the semantically correct attribute for this relationship. It exists specifically to identify error messages and pairs witharia-invalid.Testing Library and Playwright both ship
toHaveAccessibleErrorMessage()as a first-class assertion that readsaria-errormessage. I take that to mean this API should be stable and safe to support. I discovered this because I was attempting to write unit tests in my project with both of those and realized I couldn't usetoHaveAccessibleErrorMessage()out of the box with Ark UI.This change should be minimal because the infrastructure already correctly sets
aria-invalidand determineshasErrorTextwith aMutationObserver. The error text ID just needs to move fromaria-describedbytoaria-errormessage, leavingaria-describedbyfor helper text exclusively, which I believe is the correct semantic split.Thank you!