create-empty-test: removed escape sequence from double quotes#1828
Merged
Conversation
After simplifying the create-empty-test script in https://github.com/cfengine/buildscripts/pull/1815/files we no longer need to escape the double quotes. Doing so causes the literal backslash to be included causing the following error: ``` org.dom4j.DocumentException: Error on line 1 of document : The value following "version" in the XML declaration must be a quoted string. ``` Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
larsewi
requested review from
aleksandrychev,
craigcomstock,
jakub-nt,
nickanderson,
olehermanse and
victormlg
olehermanse
approved these changes
Jul 29, 2025
craigcomstock
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After simplifying the create-empty-test script in
https://github.com/cfengine/buildscripts/pull/1815/files we no longer
need to escape the double quotes. Doing so causes the literal backslash
to be included causing the following error:
Signed-off-by: Lars Erik Wik lars.erik.wik@northern.tech
Build on MinGW
