Skip to content

ENT-12600: configure: Documented and refactored script#1777

Merged
larsewi merged 9 commits into
cfengine:masterfrom
larsewi:configure
Aug 27, 2025
Merged

ENT-12600: configure: Documented and refactored script#1777
larsewi merged 9 commits into
cfengine:masterfrom
larsewi:configure

Conversation

@larsewi
Copy link
Copy Markdown
Contributor

@larsewi larsewi commented Jun 24, 2025

  • configure: Removed code duplication
  • configure: Reformatted case statements for consistency
  • configure: Remove CODE_COVERAGE build type
  • configure: Fixed shellcheck issues
  • configure: Decrease verbosity of script

Example output:

 ---snip---
configure: debug: running configure on core repo...
configure: debug: running configure on enterprise repo...
configure: debug: running configure on nova repo...
Error: Failed to run: env CFLAGS=-g2 -O1  ./configure --prefix=/var/cfengine --libdir=/var/cfengine/lib --with-workdir=/var/cfengine --sysconfdir=/etc --with-openssl=/var/cfengine --with-pcre2=/var/cfengine --with-librsync=/var/cfengine --with-init-script --with-lmdb=/var/cfengine --without-pthreads-w32 --with-ldap=/var/cfengine --with-libxml2=/var/cfengine --with-libyaml=/var/cfengine --with-librsync=/var/cfengine --with-leech=/var/cfengine --with-libacl=/var/cfengine --without-libvirt --with-libcurl=/var/cfengine --with-postgresql=/var/cfengine --without-mysql --with-cfmod --with-enterprise-api --with-postgresql=/var/cfengine --with-systemd-service --enable-debug
--- Start of Output ---
 ---snip---
configure: error: Cannot find php devel files
--- End of Output (Error Code: 1) ---

@cf-bottom
Copy link
Copy Markdown

Thanks for submitting a pull request! Maybe @craigcomstock can review this?

@larsewi larsewi marked this pull request as ready for review July 24, 2025 12:04
@larsewi larsewi requested a review from craigcomstock July 24, 2025 12:04
@larsewi larsewi marked this pull request as draft July 25, 2025 11:54
@larsewi larsewi changed the title ENT-12600: configure: Documented script ENT-12600: configure: Documented and refactored script Jul 25, 2025
@larsewi
Copy link
Copy Markdown
Contributor Author

larsewi commented Aug 4, 2025

Build with no tests
Build Status

@larsewi larsewi marked this pull request as ready for review August 11, 2025 09:06
@larsewi
Copy link
Copy Markdown
Contributor Author

larsewi commented Aug 25, 2025

Ping @craigcomstock

Copy link
Copy Markdown
Contributor

@craigcomstock craigcomstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! thanks for this hard work!

Comment thread build-scripts/configure Outdated
The code for adding the correct "configure" feature selection options
(i.e., --with-dep=/path/to/dep/, --without-dep) based on the
dependencies had a lot of repetitive code. I created a for loop for
those that are nearly identical.

Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Because we don't use it.

Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Ticket: ENT-12600
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Ticket: ENT-12600
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
We want word splitting so that the arguments are not interpreted as one
string.

Ticket: ENT-12600
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
@larsewi
Copy link
Copy Markdown
Contributor Author

larsewi commented Aug 26, 2025

@cf-bottom Jenkins please :)

@cf-bottom
Copy link
Copy Markdown

@larsewi larsewi merged commit b01578e into cfengine:master Aug 27, 2025
28 of 31 checks passed
@larsewi larsewi deleted the configure branch October 2, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants