Skip to content

ENT-12600: clean-buildmachine: Documented script#1766

Merged
larsewi merged 2 commits intocfengine:masterfrom
larsewi:clean-buildmachine
Jul 25, 2025
Merged

ENT-12600: clean-buildmachine: Documented script#1766
larsewi merged 2 commits intocfengine:masterfrom
larsewi:clean-buildmachine

Conversation

@larsewi
Copy link
Copy Markdown
Contributor

@larsewi larsewi commented Jun 20, 2025

Build with no tests
Build Status

@larsewi larsewi requested a review from craigcomstock June 23, 2025 08:59
@larsewi larsewi marked this pull request as ready for review June 23, 2025 08:59
@larsewi larsewi requested a review from olehermanse June 25, 2025 10:50
Copy link
Copy Markdown
Member

@olehermanse olehermanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but @craigcomstock is probably more qualified :)

Comment thread build-scripts/clean-buildmachine Outdated
Comment thread build-scripts/clean-buildmachine Outdated
@olehermanse olehermanse requested a review from vpodzime June 30, 2025 18:00
Copy link
Copy Markdown
Contributor

@vpodzime vpodzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@larsewi larsewi force-pushed the clean-buildmachine branch from ced0852 to 3e61f6f Compare July 24, 2025 11:28
larsewi added 2 commits July 24, 2025 13:28
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
I also:
- fixed shellcheck issues
- added an if statement to prevent accedental deletion root on AIX in
  case of prefix being empty or undefined
- added a debug log message

Ticket: ENT-12600
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
@larsewi larsewi force-pushed the clean-buildmachine branch from 3e61f6f to df57751 Compare July 24, 2025 11:28
@larsewi
Copy link
Copy Markdown
Contributor Author

larsewi commented Jul 24, 2025

Build (no tests)
Build Status

@larsewi larsewi requested a review from craigcomstock July 24, 2025 11:32
@larsewi larsewi merged commit 8039d9d into cfengine:master Jul 25, 2025
25 of 26 checks passed
@larsewi larsewi deleted the clean-buildmachine branch October 2, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants