ENT-12600: bootstrap-tarballs: Document script#1757
Merged
Conversation
larsewi
force-pushed
the
bootstrap-tarballs
branch
from
b762ba5 to
0bcf793
Compare
Comment on lines
+122
to
+134
| if test -f "$BASEDIR"/mission-portal/public/scripts/package.json; then | ||
| cd "$BASEDIR"/mission-portal/public/scripts |
Contributor
There was a problem hiding this comment.
This change isn't so needed but is fine. I often prefer to avoid the quotes as if more vars enter the expression things get noisy.
Contributor
Author
There was a problem hiding this comment.
Yeah, shellcheck warns about it
larsewi
force-pushed
the
bootstrap-tarballs
branch
2 times, most recently
from
c172f4b to
2aeef3d
Compare
Contributor
Author
|
Build with exotics (no tests) |
Contributor
craigcomstock
left a comment
craigcomstock
left a comment
There was a problem hiding this comment.
looking real good!
larsewi
force-pushed
the
bootstrap-tarballs
branch
2 times, most recently
from
990b814 to
91e9173
Compare
Ticket: ENT-12600 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Ticket: ENT-12600 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Ticket: ENT-12600 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
I feel like the installation of dependencies does not belong here. Maybe they should go in to the install-dependencies script? Ticket: ENT-12600 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
The use of `|| true` will cause an error message to be printed by `rm` which may lead QA personnel to believe that there is something wrong while there is not. -f will simply ignore nonexistent files. ``` rm: cannot remove 'nosuchfile': No such file or directory ``` Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Added a comment to the top of the file explaining what the script does and how you can run it. Ticket: ENT-12600 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
larsewi
force-pushed
the
bootstrap-tarballs
branch
from
91e9173 to
d586645
Compare
larsewi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example output:
I snipped out noise from sourced scripts.
With exotics (no tests)
Failures are unrelated: