Fix build error on windows - #288
Open
perseusdg wants to merge 10 commits into
Open
Conversation
This reverts commit d2ce966. Undo tensorrt8 changes on the master branch
This reverts commit f58776c.
This reverts commit eba78e7.
Signed-off-by: Micaela Verucchi <micaelaverucchi@gmail.com>
ceccocats/tkdnn:master -> perseusdg/tkdnn:tensorrt8
This commit has fixes in the form of __declspec(dllexport) and __declspec(dllimport) to run the tkdnn master branch on windows along with removing cmake_export_all_symbols and solely using __declspec(dllexport)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull requests fixes the issues mentioned in 287 and moves to __declspec(dllexport) and __declspec(dllimport) on a as needed basis (symbol wise per header) instead of using CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS in the cmakelists.txt