Skip to content

some change about timeout#425

Merged
yogacc33 merged 29 commits into
ccprocessor:devfrom
ddfinshes:dev
May 26, 2025
Merged

some change about timeout#425
yogacc33 merged 29 commits into
ccprocessor:devfrom
ddfinshes:dev

Conversation

@ddfinshes

Copy link
Copy Markdown
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@NgZiming

Copy link
Copy Markdown
Contributor

LGTM

if f != c:
return False

try:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return (next(full_chars, None) or next(code_chars, None)) is None

new_nodes.append(node)
nodes = new_nodes
# 过滤掉已处理的节点
nodes_deque = deque([node for node in nodes_deque if id(node) not in processed])

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这一行可能不需要,和155的功能重复了呢

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get

@codecov

codecov Bot commented May 23, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 96.96970% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...web_kit/extractor/html/recognizer/code/tag_code.py 95.83% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #425      +/-   ##
==========================================
- Coverage   89.97%   89.84%   -0.13%     
==========================================
  Files         107      102       -5     
  Lines        8288     8186     -102     
==========================================
- Hits         7457     7355     -102     
  Misses        831      831              
Files with missing lines Coverage Δ
...m_web_kit/extractor/html/recognizer/code/common.py 98.82% <100.00%> (-0.04%) ⬇️
...web_kit/extractor/html/recognizer/code/tag_code.py 95.14% <95.83%> (-0.69%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. print语句去掉,测试用例不要打印内容
  2. 最后的几句可以去掉,以test开头的function在pytest会执行测试
    sec = TestExtractorChain()
    sec.setUp()
    sec.test_timeout_exception()
  3. self.maxDiff = None 这里定义的变量有使用吗?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_math.py代码如果没有修改,还原下代码

@yogacc33 yogacc33 merged commit dd5565d into ccprocessor:dev May 26, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants