fix: verify_proofs_dleq should not early return#964
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #964 +/- ##
==========================================
+ Coverage 74.90% 75.21% +0.30%
==========================================
Files 99 99
Lines 11685 11714 +29
==========================================
+ Hits 8753 8811 +58
+ Misses 2932 2903 -29 ☔ View full report in Codecov by Sentry. |
|
lgtm |
|
just thought but i think worth adding test the bug was subtle control flow return vs continue. |
Fixes a bug where first proof without DLEQ silently skipped verification of all remaining proofs.
verify_proofs_dleqnow checks all proofs have vaiid DLEQ.