refactor: move from deprecated pkg_resources#1202
Open
JGSweets wants to merge 15 commits intocapitalone:mainfrom
Open
refactor: move from deprecated pkg_resources#1202JGSweets wants to merge 15 commits intocapitalone:mainfrom
JGSweets wants to merge 15 commits intocapitalone:mainfrom
Conversation
JGSweets
force-pushed
the
fix-pkg-resource
branch
from
c17b068 to
e11fe17
Compare
Contributor
Author
|
@ryanSoley Can we get a review on this? It will allow DP to continue working with new setuptools. Otherwise, this library will not work in system that utilize the most up to date setuptools |
Contributor
Author
|
@mhmotamedi any chances we could get a review on this for fixes? |
shania-m
reviewed
Feb 24, 2026
| from .base_model import BaseModel | ||
|
|
||
| default_labeler_dir = pkg_resources.resource_filename("resources", "labelers") | ||
| default_labeler_dir = utils.find_resources_dir() / "labelers" |
Contributor
There was a problem hiding this comment.
Nice! Something I noticed is that after the call we’re adding a subdir for each call. Can we maybe just take that as input and return the full path as well?
Contributor
Author
There was a problem hiding this comment.
That's a great idea! I'll resolve that. Do you want this pr'ed into dev instead of main?
Contributor
Author
There was a problem hiding this comment.
@shania-m done! LMK if you need other updates, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr:
include_package_datainstead ofdata_files<3.0.0