You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I considered making them conditionally empty, but empty strings will also fail the validation process. So this seems to be the least invasive approach.
@tim-sh I can continue to work on the failing tests if you are okay with the general solution, as adjusting the expected format to the actual wording we choose requires a bit of manual labor, and I'd like to not have to do that too many times, in case we decide on a different output. :)
@tim-sh I can continue to work on the failing tests if you are okay with the general solution, as adjusting the expected format to the actual wording we choose requires a bit of manual labor, and I'd like to not have to do that too many times, in case we decide on a different output. :)
Looks good to me. The additional text makes the @ obsolete and the ellipsees are anyway. As long as we don't find a lot of places where we need such special chars, I'm fine with the solution. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #135
I considered making them conditionally empty, but empty strings will also fail the validation process. So this seems to be the least invasive approach.