Skip to content

fix: Remove special characters from placeholders#139

Merged
daogrady merged 6 commits intomainfrom
fix/sap-core-v1-policy
Feb 5, 2026
Merged

fix: Remove special characters from placeholders#139
daogrady merged 6 commits intomainfrom
fix/sap-core-v1-policy

Conversation

@daogrady
Copy link
Contributor

Fixes #135

I considered making them conditionally empty, but empty strings will also fail the validation process. So this seems to be the least invasive approach.

@daogrady
Copy link
Contributor Author

@tim-sh I can continue to work on the failing tests if you are okay with the general solution, as adjusting the expected format to the actual wording we choose requires a bit of manual labor, and I'd like to not have to do that too many times, in case we decide on a different output. :)

@tim-sh
Copy link
Member

tim-sh commented Jan 29, 2026

@tim-sh I can continue to work on the failing tests if you are okay with the general solution, as adjusting the expected format to the actual wording we choose requires a bit of manual labor, and I'd like to not have to do that too many times, in case we decide on a different output. :)

Looks good to me. The additional text makes the @ obsolete and the ellipsees are anyway. As long as we don't find a lot of places where we need such special chars, I'm fine with the solution. 👍

@daogrady daogrady requested a review from tim-sh January 29, 2026 17:28
@daogrady daogrady merged commit 3dda15b into main Feb 5, 2026
10 checks passed
@daogrady daogrady deleted the fix/sap-core-v1-policy branch February 5, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generated OpenAPI document fails SAP Core v1 validation with default values

2 participants