feat: hide auth details from listNetwork and mint self-signed token server-side#1872
Merged
Conversation
The absence of the clientSecret also implies that the self-signed login can no longer be done on the frontend. Instead, the backend now must mint a self-signed token. Signed-off-by: Marc Juchli <marc.juchli@digitalasset.com>
Signed-off-by: Marc Juchli <marc.juchli@digitalasset.com>
Signed-off-by: Marc Juchli <marc.juchli@digitalasset.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1802
Since we want to hide sensitive information such as the
clientSecretto be exposed via the API, we need to handle the self-signed login server-side. This PR therefore introduces a new endpointselfSignedAccessTokento issue an access token.In a follow-up, one could think of combining this call with the creation of a
Session(currently the workflow is:selfSignedAccessToken + addSession) and return the session object to the frontend.