fix: branch result handling and strengthen tests#299
Open
mdqst wants to merge 1 commit intocamshaft:masterfrom
Open
fix: branch result handling and strengthen tests#299mdqst wants to merge 1 commit intocamshaft:masterfrom
mdqst wants to merge 1 commit intocamshaft:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updated the logic inside
for_eachto actually store the result ofbranches(x)inresult.added
assert_eq!checks to make sure the function behaves correctly for all random inputs.p.s. previously, the function was called but its output wasn't verified, so tests could pass even if the logic was wrong.
now the behavior is properly validated.