fix: Ensure CreateContainerConfigError results in SYSTEM_ERROR#1413
Draft
lbeckman314 wants to merge 4 commits into
Draft
fix: Ensure CreateContainerConfigError results in SYSTEM_ERROR#1413lbeckman314 wants to merge 4 commits into
lbeckman314 wants to merge 4 commits into
Conversation
Signed-off-by: Liam Beckman <lbeckman314@gmail.com>
Signed-off-by: Liam Beckman <lbeckman314@gmail.com>
Signed-off-by: Liam Beckman <lbeckman314@gmail.com>
Signed-off-by: Liam Beckman <lbeckman314@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates the K8s backend to ensure that K8s jobs that fail with
CreateContainerConfigErrorresult in their TES tasks being marked asSYSTEM_ERROR(as opposed to perpetually stuck inRUNNING)!Current Behavior⚠️
Caution
Tested against Helm Chart v0.1.99-rc.34 + 2026-05-11
New Behavior ✔️
Tip
Tested against Helm Chart v0.1.99-rc.34 + e5b8b96