Bump React dependency and peer dependency to 17#33
Conversation
|
Thanks! One issue is that tests are still run with 16.* due to the |
e350a21 to
f1771af
Compare
|
I had that change locally but missed pushing it. Thanks @polytypic! |
f1771af to
e34adb9
Compare
|
Hmm... One more issue came to mind. Namely that since this is upgrading React major version from 16 to 17, then it would probably be best to also change the major version number of Karet (4.1.0 -> 5.0.0). That is because React is effectively an interface dependency that leaks through. Other than that this looks good! |
|
If you make the |
e34adb9 to
ed91e35
Compare
polytypic
left a comment
There was a problem hiding this comment.
Looks good!
I thought about the possibility of not upgrading the major version of Karet, but it is conceivable that someone might be using React through Karet and in that case an unintentional major version upgrade of React might happen. So, all in all, increasing the major version of Karet should be the safer approach.
|
ping @abstracthat |
React 17 is out. I've tested this in a large Karet application and found no issues. This release will mostly just clear the npm warning for the React peer dependency.