added deployment task #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbgk
reviewed
Oct 9, 2017
| ## Deploying | ||
|
|
||
| In order to deploy to the staging server, you should have an SSH access | ||
| to the server with the _cafebabel_ user callable via the command `ssh cafebabel`. |
Contributor
There was a problem hiding this comment.
Maybe we should explicitly use ssh cafebabel@cafebabel to avoid deploying using root
Member
Author
There was a problem hiding this comment.
I've put user cafebabel in my ssh conf which makes it error proof.
Would you rather have it in your conf or type it explicitly + readme?
Contributor
There was a problem hiding this comment.
Actually at that point I would just hardcode cafebabel@ip to be explicit
davidbgk
reviewed
Oct 9, 2017
| @echo "Fetching master branch and updating sources." | ||
| ssh cafebabel "${goto_src} && git fetch origin master && git checkout master && git reset --hard FETCH_HEAD" | ||
| ssh cafebabel "${goto_src} && pip install -r requirements.txt" | ||
| ssh cafebabel "${goto_src} && python app.py 0.0.0.0:5000 &" |
Contributor
There was a problem hiding this comment.
So no gunicorn+nginx at that point?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.