fix: ServerHash regex off-by-one in listen channel#1407
Merged
Conversation
Groups[2] doesn't exist; the hash is in Groups[1]. The empty ServerHash caused server-multipliers events to fall into the creature import branch and be silently dropped. Cluster rates now auto-apply on the next push.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The regex
^event: server (\-?\d+)$captures the hash inGroups[1], but the code readsGroups[2].ServerHashis therefore always empty forevent: serverevents, which makesAsbServerDataSentroute the multipliers JSON into the creature-import branch where it fails silently (noBlueprintPath) and gets dropped.@coldino confirmed on #1406 that the mod is sending multipliers through the export server — so the mechanism was correct, ASB just wasn't parsing the hash.
Fix
Test plan
.\build.ps1— builds, 64/64 tests pass.event: serverevents arriving; after the fix the cluster's actual values (Taming 5x, EggHatch 5x, BabyMature 5x, etc.) auto-apply on the next push from the mod.