Add "Add All" and "Sync All" buttons to Albums view#5
Open
b0x42 wants to merge 2 commits into
Open
Conversation
OperationQueue() defaults to concurrent, so URLSession was firing delegate callbacks on multiple threads simultaneously. This caused data races on loggedMilestones (Set<Int>), corrupting the heap and producing SIGSEGV/SIGABRT/EXC_BREAKPOINT crashes in UploadProgressDelegate, CFNetwork's nghttp2 stack, and the JSON decoder. Setting maxConcurrentOperationCount = 1 makes the queue serial, matching the existing "serial delegate queue" comment and eliminating the race. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- "Add All" appears next to "Load Albums" once unmapped albums are loaded; queues all unmapped albums to Immich sequentially - "Sync All" appears in the Synced Albums header; syncs every mapped album in sequence, updating asset counts as each finishes - Both buttons show a disabled "Adding…" / "Syncing…" state while in progress and surface an error message if any single album fails Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Albums view requires clicking "Add to Immich" and "Sync" individually for every album. With many albums this is tedious — there's no way to bulk-add or bulk-sync in one go.
Solution
Both buttons are disabled during their operation, surface an error message if any single album fails, and stop early rather than silently skipping failures.
Test plan