This repository was archived by the owner on May 3, 2023. It is now read-only.
Handle google/protobuf/wrappers.proto types on protoc-gen-openapi#1
Open
galihputera wants to merge 9 commits into
Open
Handle google/protobuf/wrappers.proto types on protoc-gen-openapi#1galihputera wants to merge 9 commits into
galihputera wants to merge 9 commits into
Conversation
chaayac
approved these changes
Sep 1, 2022
chaayac
left a comment
There was a problem hiding this comment.
looks good, you should add the test outputs to the upstream as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to https://developers.google.com/protocol-buffers/docs/proto3#json, Wrapper Types use the same representation in JSON as the wrapped primitive type. On this MR I Modify protoc-gen-openapi code to be able to parse Wrapper Types on schema and parameters.
Also in this MR is changes to map

google.protobuf.Timestampfield into string when used as URL query parameters. Previously it will be mapped into two separate fields, for exampletimestamp_typewill mapped intotimestampType.secondsandtimestampType.nanosManual Testing
Unit Test
Steps
Result
Check generated openapi using Swagger UI
Command
Result on Query String
Result on Schema