Fix silent script failure from ((var++)) with set -e #328
+13
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a bash arithmetic expression ((var++)) is evaluated and var is 0, the post-increment returns the old value (0), which bash treats as a failure exit status. Combined with set -e, this silently kills the script. This caused project-install.sh to exit immediately after printing "Configuration:" without performing any installation. Fix by appending `|| true` to all standalone ((var++)) expressions so the zero-return doesn't trigger set -e. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
project-install.shsilently exits after printing "Configuration:" without installing anything((var++))returns exit status 1 whenvaris 0 (post-increment returns the old value), andset -etreats this as a fatal error((var++))expressions acrossproject-install.sh,common-functions.sh, andsync-to-profile.shby appending|| trueSteps to reproduce
cd /path/to/any/project /path/to/agent-os/scripts/project-install.shOutput stops at "Configuration:" and no files are installed.
Test plan
project-install.shnow completes successfully and installs all 5 commandssync-to-profile.shworks with the same fix pattern🤖 Generated with Claude Code