This repository was archived by the owner on Jan 8, 2024. It is now read-only.
Fix issue with hidden second line of tabs When there are two lines#185
Open
eddy5885 wants to merge 1 commit intobrrd:masterfrom
Open
Fix issue with hidden second line of tabs When there are two lines#185eddy5885 wants to merge 1 commit intobrrd:masterfrom
eddy5885 wants to merge 1 commit intobrrd:masterfrom
Conversation
|
In apps, I think tabs tend to scroll sideways instead of stacking... Example, my app that uses Electron Tabs: Screen.Recording.2023-05-09.at.10.02.46.PM.movExample, macOS Finder: Screen.Recording.2023-05-09.at.10.00.53.PM.mov |
|
@SudoVanilla you got a cool implementation. whats your app name? |
|
@eshwaruppala That app I've built with Electron Tabs is Penpot Desktop. |
|
@SudoVanilla Thanks for the prompt reply. I am going through the code and trying to understand how you built it. How can i theme my tabs like yours? The scrollbar is due to the fix you added using css? Edit: I got it :) |
|
Closed this issue if it doesn't need to be opened anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there are multiple lines of tabs, the second line is not visible.Because the grandfather tag of the tabs has a fixed height of 32px, the second line and onwards are hidden when there are multiple rows. Removing the fixed height and allowing the height to adapt automatically can fix this issue. Additionally, if the z-index of the content area of the web view is too high, the tabs may not be visible.
This issue can be fixed by following: #128
@da201501245