Fix/consensus/sync#1088
Open
Mododo wants to merge 3 commits into
Open
Conversation
* move peer resolve out of task tracker * download task copy could resolve into `Cancelled()` when its round is dropped * allow one restart on TKA used to start
🧪 Network TestsTo run network tests for this PR, use: gh workflow run network-tests.yml -f pr_number=1088Available test options:
Test types: Results will be posted as workflow runs in the Actions tab. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1088 +/- ##
==========================================
+ Coverage 57.57% 57.62% +0.05%
==========================================
Files 464 464
Lines 77109 77128 +19
Branches 77109 77128 +19
==========================================
+ Hits 44395 44445 +50
+ Misses 30701 30663 -38
- Partials 2013 2020 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Mododo
force-pushed
the
fix/consensus/sync
branch
from
6136a0b to
3e9d562
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
NODE CONFIGURATION MODEL CHANGES
Yes
Added mempool node config param
weak_dag_round_linkswith default7.BLOCKCHAIN CONFIGURATION MODEL CHANGES
None
COMPATIBILITY
Full
SPECIAL DEPLOYMENT ACTIONS
Not Required
PERFORMANCE IMPACT
No impact expected
TESTS
Unit Tests
No coverage
Network Tests
No coverage
Manual Tests
transfers-30k with node sync and manual vset change
Notes/Additional Comments: