Fix assets syntax errors#4
Open
radanskoric wants to merge 2 commits into
Open
Conversation
Author
|
Is there something I can do to get this merged in? Is there something wrong with the changesets? Thank you in advance. |
|
+1 for this patch Please merge, otherwise this plugin is rather unusable on production systems where the assets need to be precompiled. The precompiler fails awfully because of the syntax errors. Thanks! |
|
+1 |
1 similar comment
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some css files are using:
That is incorrect css syntax. Instead, "opacity=50" should be used. If assets pipeline is enabled with Sass compiler it will throw an error during rake assets:precompile task. For example that prevents a project that uses it to be deployed to Heroku.
This pull requests fixes those occurences of opacity filter.