test user data dir spec in CI on windows #1468
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
Greptile SummaryAdded Windows CI job to test
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant GH as GitHub Actions
participant Win as Windows Runner
participant PNPM as pnpm
participant Test as Playwright Test
participant V3 as V3 Instance
participant Chrome as Chrome Launcher
participant FS as File System
GH->>Win: Trigger run-windows-user-data-dir-test
Win->>Win: Checkout code
Win->>Win: Setup Node.js & pnpm
Win->>PNPM: pnpm install --frozen-lockfile
PNPM-->>Win: Dependencies installed
Win->>Test: Run user-data-dir.spec.ts
Test->>FS: Create temp dir (mkdtempSync)
FS-->>Test: testDir path
Test->>V3: Initialize with userDataDir config
V3->>Chrome: Launch with --user-data-dir flag
Chrome->>FS: Create profile directories
FS->>FS: Write "Default" folder
FS->>FS: Write "Local State" file
Test->>FS: Poll for "Default" directory
FS-->>Test: Directory exists
Test->>FS: Check "Local State" file
FS-->>Test: File exists
Test->>V3: close()
V3->>Chrome: Kill process
Test->>FS: rmSync(testDir)
FS-->>Test: Cleanup complete
Test-->>Win: Test passed/failed
Win-->>GH: Job complete (blocks other jobs)
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/core/lib/v3/tests/user-data-dir.spec.ts">
<violation number="1" location="packages/core/lib/v3/tests/user-data-dir.spec.ts:46">
P2: The second file existence check should also use `expect.poll()` for consistency and to avoid flaky tests. If `Default` directory needs polling due to timing, `Local State` file likely does too.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
| }) | ||
| .toBe(true); | ||
|
|
||
| expect(fs.existsSync(path.join(testDir, "Local State"))).toBe(true); |
Contributor
There was a problem hiding this comment.
P2: The second file existence check should also use expect.poll() for consistency and to avoid flaky tests. If Default directory needs polling due to timing, Local State file likely does too.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/core/lib/v3/tests/user-data-dir.spec.ts, line 46:
<comment>The second file existence check should also use `expect.poll()` for consistency and to avoid flaky tests. If `Default` directory needs polling due to timing, `Local State` file likely does too.</comment>
<file context>
@@ -0,0 +1,48 @@
+ })
+ .toBe(true);
+
+ expect(fs.existsSync(path.join(testDir, "Local State"))).toBe(true);
+ });
+});
</file context>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Run a Windows CI job to execute a Playwright test that verifies Chrome writes profile data to the provided userDataDir. This helps reproduce and diagnose Windows-specific issues in the V3 local browser launcher and gates later CI steps on this check.
Bug Fixes
Refactors
Written for commit c741e6e. Summary will update automatically on new commits.