Skip to content

Fix argument handling in rustic-cargo-clippy-rerun #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kritzefitz wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix argument handling in rustic-cargo-clippy-rerun #458

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab84300
Fix argument handling in `rustic-cargo-clippy-rerun`
Kritzefitz Nov 7, 2022
e57139d
Always set `rustic-clippy-arguments` in `rustic-cargo-clippy`
Kritzefitz Nov 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions rustic-clippy.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,21 +78,22 @@ If ARG is not nil, use value as argument and store it in `rustic-clippy-argument
When calling this function from `rustic-popup-mode', always use the value of
`rustic-clippy-arguments'."
(interactive "P")
(rustic-cargo-clippy-run
:params (cond (arg
(setq rustic-clippy-arguments (read-from-minibuffer "Cargo clippy arguments: " rustic-default-clippy-arguments)))
((eq major-mode 'rustic-popup-mode)
(if (> (length rustic-clippy-arguments) 0)
rustic-clippy-arguments
rustic-default-clippy-arguments))
(t
rustic-default-clippy-arguments))))
(setq rustic-clippy-arguments (cond
(arg
(read-from-minibuffer "Cargo clippy arguments: " rustic-default-clippy-arguments))
((eq major-mode 'rustic-popup-mode)
(if (> (length rustic-clippy-arguments) 0)
rustic-clippy-arguments
rustic-default-clippy-arguments))
(t
rustic-default-clippy-arguments)))
(rustic-cargo-clippy-run :params rustic-clippy-arguments))

;;;###autoload
(defun rustic-cargo-clippy-rerun ()
"Run 'cargo clippy' with `rustic-clippy-arguments'."
(interactive)
(rustic-cargo-clippy-run rustic-clippy-arguments))
(rustic-cargo-clippy-run :params rustic-clippy-arguments))

(defun rustic-cargo-clippy-fix (&rest args)
"Run 'clippy fix'."
Expand Down