This repository was archived by the owner on Apr 17, 2019. It is now read-only.
Added singleton support so that no need to create property in application delegate.#2
Open
Janak-Nirmal wants to merge 3 commits into
Open
Added singleton support so that no need to create property in application delegate.#2Janak-Nirmal wants to merge 3 commits into
Janak-Nirmal wants to merge 3 commits into
Conversation
|
just cloned repo and learning the design of theme loader but adding singleton pattern makes sense. |
|
I don't have an opinion about whether a singleton is necessary or not, but if you do implement the singleton, it might be better to do it using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.