Skip to content

Add GIN to linkcheck ignore list#499

Merged
adamltyson merged 3 commits into
mainfrom
linkcheck-ignore-gin
May 21, 2026
Merged

Add GIN to linkcheck ignore list#499
adamltyson merged 3 commits into
mainfrom
linkcheck-ignore-gin

Conversation

@alessandrofelder

@alessandrofelder alessandrofelder commented May 20, 2026

Copy link
Copy Markdown
Member

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

GIN being down seems to be the root cause of build errors, including on main, and leading to a mismatch between the code on main and brainglobe.info.

We will still be notified of GIN being down via our scheduled (e.g. Atlas API) tests.

What does this PR do?

Adds GIN's URL to ignore-list for link checker.

References

Closes #494

How has this PR been tested?

Keeping this PR in draft until CI passes.
I will continue to check in on the build and triple-check but hard to test locally.

Is this a breaking change?

Nope.

Does this PR require an update to the documentation?

Is one.

@alessandrofelder alessandrofelder marked this pull request as ready for review May 21, 2026 12:55
@alessandrofelder

alessandrofelder commented May 21, 2026

Copy link
Copy Markdown
Member Author

uol.de was throttling us last night but seems to be fine after rerunning CI now (if that happens again, we can add it to the ignore list).

Generally, we might want to ignore/skip linkcheck errors after merging, so main and what is renders on the website are always in-sync: neuroinformatics-unit/actions#163

@alessandrofelder alessandrofelder requested a review from a team May 21, 2026 13:01
@adamltyson

Copy link
Copy Markdown
Member

uol.de was throttling us last night but seems to be fine after rerunning CI now (if that happens again, we can add it to the ignore list).

I think this happens with most websites occasionally, I don't think we should just add everything to link check, otherwise we may as well not bother having it! I think the issue is just because we have so many links, and many of these are to academic sites and small blogs etc, that at any time the likelihood of >1 of them being down is pretty high.

@adamltyson adamltyson merged commit c1829db into main May 21, 2026
6 of 7 checks passed
@adamltyson adamltyson deleted the linkcheck-ignore-gin branch May 21, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] CI failures for website build

2 participants