Syncing from upstream OCA/server-tools (19.0)#2006
Merged
bt-admin merged 44 commits intobrain-tec:19.0from Feb 14, 2026
Merged
Conversation
Currently translated at 100.0% (2 of 2 strings) Translation: server-tools-16.0/server-tools-16.0-base_partition Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_partition/es/
Currently translated at 100.0% (2 of 2 strings) Translation: server-tools-16.0/server-tools-16.0-base_partition Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_partition/it/
Currently translated at 100.0% (2 of 2 strings) Translation: server-tools-17.0/server-tools-17.0-base_partition Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-base_partition/zh_CN/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-18.0/server-tools-18.0-base_partition Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-base_partition/
- Add proper string conversion for non-string return values from Python code
in sequence evaluation to prevent TypeError during string concatenation
- Use isinstance check to only convert non-string values, preserving
original behavior for string results
- Add test case to verify handling of integer return values from Python code
- Use separate sequence in test to avoid interference with other tests
The fix ensures that when Python code in sequence evaluation returns
non-string values (like integers), they are properly converted to strings
before concatenation with prefix and suffix, preventing TypeError.
Fixes potential issue where Python expressions returning integers or
other non-string types would cause concatenation errors.
- Move UUID safe members computation to module level as a constant - Replace repeated computation in _get_python_eval_context with constant lookup - Use _UUID_SAFE_MEMBERS constant instead of computing uuid_elements on each call - Improves performance by avoiding redundant computation on every sequence evaluation This optimization pre-computes the UUID safe members list once at module import time instead of recomputing it on every call to _get_python_eval_context, which can happen frequently during sequence operations.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 19.0 #2006 +/- ##
==========================================
+ Coverage 76.70% 77.57% +0.87%
==========================================
Files 130 140 +10
Lines 4262 4441 +179
Branches 567 582 +15
==========================================
+ Hits 3269 3445 +176
- Misses 840 842 +2
- Partials 153 154 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bt_gitbot