Syncing from upstream odoo/runbot (19.0-cache-docker-add-moc)#1008
Open
bt-admin wants to merge 19 commits intobrain-tec:19.0-cache-docker-add-mocfrom
Open
Syncing from upstream odoo/runbot (19.0-cache-docker-add-moc)#1008bt-admin wants to merge 19 commits intobrain-tec:19.0-cache-docker-add-mocfrom
bt-admin wants to merge 19 commits intobrain-tec:19.0-cache-docker-add-mocfrom
Conversation
Since the commit [^1] deferring the loading of the runbot frontend JS bundle, the stats page broke due to a jQuery call being made before the actual load of the page. This commit properly moves it in the "onload" listener. [^1]: 9940718
This commit fxes all remaining upgrades usage to work with the upgrade matrix and removes the old code.
d-fence
force-pushed
the
19.0-cache-docker-add-moc
branch
3 times, most recently
from
7570ff6 to
e133573
Compare
When a build error has test-tags, a red ribbon is displayed but when the user scrolls the ribbon is not visible anymore. In that case, it happens that an error is archived while having disabling tags. With this commit, test active field is displayed in red with a warning sign in order to bring user attention.
Before this commit, build error's random field is recomputed on error_content_ids change. But flagging an existing error content as random doesn't change it (which could be useful when manually flagging one as such). This commit adapts the dependency accordingly. Also, it allows to manually flag tbe BuildError as random.
Before this commit, and since the update to Odoo 19.0, click/middle-click on FrontendUrl fields in list view opened the record's modal form view in addition to the actual link in a new tab. This commit fixes it by stopping the event's propagation beyond the actual `<a>` tag. Steps to reproduce: - open an error's form view, - in the Error Content list view, click on the first/last seen date - related build link opens in a new tab => the error's form view also opens in modal
Obvisoulsy #1312 was not enough, it was only applied on BuildErrorContent. So it was working when all build error contents had the same version ids or if they appeared in the right order. With this commit, the sorting is applied on the build error computed versions.
- Add breaking pr to the fields to merge - Add a test
IF a new root file is added in a repo, don't add codeowner fallback and make the build fails since it is most likely an error. This will avoid codeowner fallback to be notified on all pr introducing trash file at the root.
When a user is assigned as a responsible to a build error, he cannot interact with the error unless being an admin or an error manager. With this commit, any runbot user can modify some pre defined fields on build error : - responsible - fixing_pr_id - breaking_pr_id - customer - random - team_id
Before this commit, to export some threehash, the commit is used to check if the commit is present or not. This can be a problem when rebuilding an old build that was linked to a previous one by a threehash after a forcepush, because the old commit may not be known by github anymore. Not sure why it was the case since it looks like fetch works fine with a threehash, so fixing it by fetching the threehash should be enough.
When a last batch is in prepare mode there no builds available on it yet. As the build is only used to extract the version information, the laste done batch can be used instead to ensure that a build is available.
d-fence
force-pushed
the
19.0-cache-docker-add-moc
branch
5 times, most recently
from
e3b48bc to
4a683f4
Compare
The `ADD` directive used for remote resources sometimes fails when the resource is not available. In order to avoid that kind of failure, this commit adds a kind of cache of those resources. In order to do that, the `ADD http...` directives are converted into `COPY` and the distant resource is downloaded in a cache directory when a `# CACHE xxxx` comment is found just before the `ADD`. Where `xxxx`is the cache validity duration in seconds.
d-fence
force-pushed
the
19.0-cache-docker-add-moc
branch
from
4a683f4 to
1198b1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bt_gitbot