Make timeline a reusable component#162
Open
alexandergknoll wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for argomaps ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
emilyrbowe
requested review from
emilyrbowe
and removed request for
ebenenglish
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to load timeline data dynamically (fetching by filename passed as a prop) I relocated the main timeline.json file to the
/public/contentdirectory. I couldn't immediately figure out how to dyamically import data from the/contentdirectory before vue is initialized and props are loaded. Let me know if you foresee any issues related to that!