Fix zip usage for compatibility with python 3 #25
Open
mxmpl wants to merge 1 commit intobootphon:masterfrom
Open
Fix zip usage for compatibility with python 3 #25mxmpl wants to merge 1 commit intobootphon:masterfrom
mxmpl wants to merge 1 commit intobootphon:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Python 3,
zipreturns an iterator and not a list as in Python 2: it exhausts once it has been iterated over.This behaviour causes issues in
abkhazia/abkhazia/corpus/corpus_merge_wavs.py
Lines 87 to 89 in 79632be
as
self.uttsis defined inabkhazia/abkhazia/corpus/corpus_merge_wavs.py
Line 61 in 79632be
For the first
spkr,spk_uttsis correct, but for the next ones it is an empty list asself.uttsis exhausted.This PR fixes this by changing
zip(...)tolist(zip(...)).