Skip to content

Correct functions to prevent dangling string #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kris-jusiak merged 2 commits into from
Feb 14, 2026
Merged

Correct functions to prevent dangling string #710

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d1a84c
correct functions to prevent dangling string
ILer32 Feb 12, 2026
d68a461
improve struct test to prevent dangling string
ILer32 Feb 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 25 additions & 17 deletions include/boost/ut.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2240,9 +2240,17 @@ struct test_location {

struct test {
std::string_view type{};
std::optional<std::string> backingName;
std::string_view name{};
std::vector<std::string_view> tag{};

test(std::string_view t, std::string_view sv) : type(t), name(sv) {}
test(std::string_view t, const std::string& s) : type(t), name(s) {}
test(std::string_view t, const char* s) : type(t), name(s) {}
template <std::size_t N>
test(std::string_view t, const char (&s)[N]) : type(t), name(s) {}
test(std::string_view t, std::string&& s) : type(t), backingName(std::move(s)), name(*backingName) {}

template <class... Ts>
constexpr auto operator=(test_location<void (*)()> _test) {
on<Ts...>(events::test<void (*)()>{.type = type,
Expand Down Expand Up @@ -3078,11 +3086,11 @@ struct suite {

[[maybe_unused]] inline auto log = detail::log{};
[[maybe_unused]] inline auto that = detail::that_{};
[[maybe_unused]] constexpr auto test = [](const auto name) {
return detail::test{"test", name};
[[maybe_unused]] constexpr auto test = [](auto&& name) {
return detail::test{"test", std::forward<decltype(name)>(name)};
};
[[maybe_unused]] constexpr auto should = test;
[[maybe_unused]] inline auto tag = [](const auto name) {
[[maybe_unused]] inline auto tag = [](const auto& name) {
return detail::tag{{name}};
};
[[maybe_unused]] inline auto skip = tag("skip");
Expand Down Expand Up @@ -3139,20 +3147,20 @@ template <class T>
}

namespace bdd {
[[maybe_unused]] constexpr auto feature = [](const auto name) {
return detail::test{"feature", name};
[[maybe_unused]] constexpr auto feature = [](auto&& name) {
return detail::test{"feature", std::forward<decltype(name)>(name)};
};
[[maybe_unused]] constexpr auto scenario = [](const auto name) {
return detail::test{"scenario", name};
[[maybe_unused]] constexpr auto scenario = [](auto&& name) {
return detail::test{"scenario", std::forward<decltype(name)>(name)};
};
[[maybe_unused]] constexpr auto given = [](const auto name) {
return detail::test{"given", name};
[[maybe_unused]] constexpr auto given = [](auto&& name) {
return detail::test{"given", std::forward<decltype(name)>(name)};
};
[[maybe_unused]] constexpr auto when = [](const auto name) {
return detail::test{"when", name};
[[maybe_unused]] constexpr auto when = [](auto&& name) {
return detail::test{"when", std::forward<decltype(name)>(name)};
};
[[maybe_unused]] constexpr auto then = [](const auto name) {
return detail::test{"then", name};
[[maybe_unused]] constexpr auto then = [](auto&& name) {
return detail::test{"then", std::forward<decltype(name)>(name)};
};

namespace gherkin {
Expand Down Expand Up @@ -3283,11 +3291,11 @@ class steps {
} // namespace bdd

namespace spec {
[[maybe_unused]] constexpr auto describe = [](const auto name) {
return detail::test{"describe", name};
[[maybe_unused]] constexpr auto describe = [](auto&& name) {
return detail::test{"describe", std::forward<decltype(name)>(name)};
};
[[maybe_unused]] constexpr auto it = [](const auto name) {
return detail::test{"it", name};
[[maybe_unused]] constexpr auto it = [](auto&& name) {
return detail::test{"it", std::forward<decltype(name)>(name)};
};
} // namespace spec

Expand Down
Loading