Added reply to review 2#2
Closed
jo-mueller wants to merge 80 commits into
Closed
Conversation
Add a comment ot RFC 4
Migrate spec subdirectories to submodules (fix ome#271)
Derived from the Anatomical_terms_of_location wikipedia article. Co-authored-by: neurolabusc <rorden@sc.edu>
Since the migration to the readthedocs, the spec-prod repository is no longer needed for building the specification.
This reverts the addition of an index.md to omit all of these files from the build for the moment. With the addition of an empty String.md file, this removes all warnings from this PR.
Automated Review URLs |
Author
|
Haven't been asked on my opinion, but I'm undecided on this one:
I'd lean a bit towards the pro side. |
bogovicj
pushed a commit
that referenced
this pull request
Dec 1, 2025
bogovicj
pushed a commit
that referenced
this pull request
Dec 1, 2025
Add my re-review (#2) of RFC-2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @bogovicj , I took the liberty of adding the replies to Review 2. From the text you had already written I hope I got the important ideas right!