Fix UnauthorizedAccessException during Roblox extraction#6504
Open
Naiml007 wants to merge 2 commits into
Open
Conversation
- Wait for killed Roblox processes to fully exit before touching files - Add 1s delay after killing processes to let OS release file handles - Retry Directory.Delete up to 5 times with 1s delays - Strip read-only attributes from version directory before extraction - Add retry loop around SharpZipLib extraction (3 attempts, 1s apart)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6500.
This PR improves upgrade/extraction handling for cases where
RobloxPlayerBeta.exeis temporarily unavailable and Bloxstrap throws:System.UnauthorizedAccessException: Access to the path ... RobloxPlayerBeta.exe is denied.Changes
Why
The original failure can happen when Bloxstrap tries to overwrite/extract Roblox files while they are still locked by:
These changes make transient locks more likely to recover and make persistent failures easier to diagnose.
Testing
dotnet build.NET 6.0-windowsis out of support