feat: report "use no memo" opt-outs as skipped instead of failed#77
Open
blazejkustra wants to merge 2 commits into
Open
feat: report "use no memo" opt-outs as skipped instead of failed#77blazejkustra wants to merge 2 commits into
blazejkustra wants to merge 2 commits into
Conversation
Closes #73. Functions annotated with `"use no memo"` / `"use no forget"` were previously surfaced under the failed bucket because the language server only handled `CompileSuccess` / `CompileError` events from the compiler and silently dropped `CompileSkip`. This change adds a third bucket end-to-end: - Server: capture `CompileSkip` events and plumb them through inlay hints, hover tooltips, and the report data model. New `skippedEmoji` setting (default `⏭️`). - Report: third counter in the summary bar, "Skipped only" status filter, neutral text class for skip rows, and skip rows excluded from the "Fix with AI" markdown collector. - Clients: `skippedEmoji` setting added for VS Code, IntelliJ, Neovim, and Zed; CLI text formatter shows skipped totals and a per-component list. - Test: new `use-no-memo.tsx` fixture asserting opt-outs land in the skipped bucket and never overlap a failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #73. Functions annotated with
"use no memo"/"use no forget"were previously surfaced under the failed bucket because the language server only handledCompileSuccess/CompileErrorevents and silently droppedCompileSkip.This PR adds a third skipped bucket end-to-end so opted-out components are no longer flagged as failures.
CompileSkipevents, plumb them through inlay hints, hover tooltips, and the report data model. NewskippedEmojisetting (default⏭️).skippedEmojisetting added for VS Code, IntelliJ, Neovim, and Zed; CLI text formatter shows skipped totals and a per-component list.use-no-memo.tsxfixture asserts opt-outs land in the skipped bucket and never overlap a failure.Test plan
npm run typecheck— cleannpm run lint— cleannpm test --prefix packages/vscode-client— 13 passing, including the new opt-out fixture case