fix: patch update.sh to fully resolve Shellcheck SC2155 & SC1083 warnings - #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR resolves the final instances of Shellcheck verification failures that were failing our main GitHub Action CI when scanning the repository root.
What's Changed
When the CI scanned the
./update.shscript, it flagged two issues affecting bash stability and POSIX standard definitions:SC1083(Literal Braces): Thegit rev-parse @{u}execution contained literal{ }characters in the unquoted string@{u}. Though usually parsed correctly by bash, strictly enforcing explicit quotes ("@{u}") is the certified POSIX bash standard for stability.SC2155(Masking Subshell Return Values): The script originally contained explicit assignment inside the local declaration (local LOCAL=$(...)). If the subshell ($(...)) fails, thelocalconstructor immediately overrides the negative return code with its own0(success). Because of this, we split the declarations strictly: