Skip to content

PM-35200 - Create contributing guide for Claude tooling#195

Merged
theMickster merged 1 commit into
mainfrom
adding-claude-contribution-guide
Apr 30, 2026
Merged

PM-35200 - Create contributing guide for Claude tooling#195
theMickster merged 1 commit into
mainfrom
adding-claude-contribution-guide

Conversation

@theMickster
Copy link
Copy Markdown
Contributor

@theMickster theMickster commented Apr 29, 2026

🎟️ Tracking

PM-35200

📔 Objective

Craft guidance for engineers to understand contributing to Claude tooling.
Adding it to the template so that all future repos have the guidance.
The guidance in the other-side-of-the-coin for ai-plugins/pull/88.
The guidance is a generic application of the work done for the server repo in server/pull/7508.

@theMickster theMickster requested a review from a team as a code owner April 29, 2026 07:56
@theMickster theMickster added the ai-review Request a Claude code review label Apr 29, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 29, 2026

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR adds .claude/CONTRIBUTING.md, a 101-line documentation-only guide explaining how engineers should contribute Claude tooling to this repo. The guide covers when to contribute here vs. bitwarden/ai-plugins, how to choose scope and shape (CLAUDE.md, rules, skills, agents, commands, hooks), security conventions for vault/auth/crypto-touching skills, and an iterative build workflow. The content is grounded, follows the active-voice style it advocates, and links to canonical Anthropic and Bitwarden references.

Code Review Details

No findings. The change is documentation-only with no code, dependency, or security surface. Title and description (with Jira tracking and cross-repo context) are adequate; no test plan is needed for a docs-only change.

@github-actions
Copy link
Copy Markdown

Logo
Checkmarx One – Scan Summary & Details478f9a83-38d2-4069-b8f4-a345f0db5d5b

Great job! No new security vulnerabilities introduced in this pull request

Comment thread .claude/CONTRIBUTING.md
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Why is this +101 but bitwarden/sdk-internal#1008 is +130? Do those larger PR's need to have prettier run on them, or does this repo have different prettier rules?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran prettier on all of those repos's PRs and this one. I also saw similar minor differences.
I didn't dig too deep, but I think the answer to your second question is Yes.

@theMickster theMickster merged commit 29661ba into main Apr 30, 2026
24 checks passed
@theMickster theMickster deleted the adding-claude-contribution-guide branch April 30, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants